Skip to content

feat(Flags): Show flag dependencies on the Value tab - #8989

Merged
khvn26 merged 12 commits into
mainfrom
feat/flag-dependencies-value-tab
Nov 18, 2026
Merged

khvn26 merged 12 commits into
mainfrom
feat/flag-dependencies-value-tab

Conversation

@khvn26

@khvn26 khvn26 commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Closes #8855.
Closes ENG-654.

In this PR, we show a flag's dependencies outside its Dependencies tab:

  • The Value tab warns when prerequisites serve the flag off in the environment, as the Dependencies tab does, with a button to the flag's dependencies.
  • The Dependencies tab's label counts the prerequisites met, e.g. 1/2, highlighted while any is off.

Both show wherever the Dependencies tab does, i.e. not for identity overrides or change requests, and only once the flag's dependencies and the feature list have loaded, as prerequisites would read as off without the latter.

We also read whether flags are on from every page of the feature list, rather than its first 999 flags, which read any prerequisite beyond them as off, in this PR and the Dependencies tab alike.

Screenshots

A flag with two prerequisites, one of them off:

The Value tab, warning that the flag is served off in Production as 1 of 2 prerequisites are off

The tab's counter:

The Dependencies tab's label, counting 1 of 2 prerequisites met

"View dependencies" opens the Dependencies tab:

The Dependencies tab, listing the two prerequisites

With both prerequisites on, the counter turns neutral and the warning goes:

The Dependencies tab, counting 2 of 2 prerequisites met, with no warning

How did you test this code?

Added unit tests for counting the prerequisites met, and steps to the flag dependencies E2E test.

The Value tab warns when prerequisites serve the flag off, linking to its
dependencies, and the Dependencies tab counts the prerequisites met.
@vercel

vercel Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
flagsmith-frontend-preview Ready Ready Preview Nov 18, 2026 2:27pm UTC
flagsmith-frontend-staging Ready Ready Preview Nov 18, 2026 2:27pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Preview Nov 18, 2026 2:27pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Explain Change →

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • Resume reviews
  • Trigger review
Walkthrough

The feature modal now loads prerequisite status for eligible existing features. The Dependencies tab displays a count of met prerequisites. When prerequisite rows and an environment name are available, the Value tab displays a blocked banner with an optional “View dependencies” action. End-to-end checks cover the count, blocked message, tab navigation, and count after enabling the prerequisite.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Severity of issue fixed: Low

Merge Risk: Low · previous review 7eeb8

The change adds prerequisite status to the Value and Dependencies tabs and now reads flag states across all pages. Remaining issues are minor: the banner count can disagree with the badge when custom dependencies exist, a late save error can be lost after tab switching, and the manual visual-baseline script cannot run before this UI merges. Nothing here blocks merging.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown

Add Carrot credits or activate Agent usage billing to use Autofix

@khvn26
khvn26 marked this pull request as ready for review November 17, 2026 17:08
@khvn26
khvn26 requested a review from a team as a code owner November 17, 2026 17:08
@khvn26
khvn26 requested review from talissoncosta and removed request for a team November 17, 2026 17:08
@github-actions github-actions Bot removed the feature New feature or request label Nov 17, 2026
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-frontend:pr-8989 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api-test:pr-8989 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-8989 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-8989 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-8989 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-8989 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-8989 Finished ✅ Results ✅

@github-actions github-actions Bot added the feature New feature or request label Nov 17, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 9 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 088bcca4-7260-4e82-b326-891fd59b8bd0
Commits

Reviewing files that changed from the base of the PR and between da995e7 and 1cd8492.

Files selected for processing: 9

  • frontend/e2e/tests/flag-dependencies-test.pw.ts
  • frontend/web/components/modals/create-feature/index.tsx
  • frontend/web/components/modals/create-feature/tabs/FeatureDependenciesTab/BlockedBanner.tsx
  • frontend/web/components/modals/create-feature/tabs/FeatureDependenciesTab/DependenciesTabLabel.tsx
  • frontend/web/components/modals/create-feature/tabs/FeatureDependenciesTab/__tests__/prerequisiteState.test.ts
  • frontend/web/components/modals/create-feature/tabs/FeatureDependenciesTab/hooks/usePrerequisiteStatus.ts
  • frontend/web/components/modals/create-feature/tabs/FeatureDependenciesTab/index.ts
  • frontend/web/components/modals/create-feature/tabs/FeatureDependenciesTab/prerequisiteState.ts
  • frontend/web/components/modals/create-feature/tabs/FeatureValueTab.tsx

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor
✅ private-cloud · depot-ubuntu-latest-16 — run #23415 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  42.4 seconds
commit  aad90ce
info  🔄 Run: #23415 (attempt 1)

🗂️ Previous results
✅ private-cloud · depot-ubuntu-latest-arm-16 — run #23415 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  36.2 seconds
commit  aad90ce
info  🔄 Run: #23415 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #23415 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  34.1 seconds
commit  aad90ce
info  🔄 Run: #23415 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #23414 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  52.3 seconds
commit  3f4b8f1
info  🔄 Run: #23414 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #23415 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  33.9 seconds
commit  aad90ce
info  🔄 Run: #23415 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #23414 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  5 passed

Details

stats  5 tests across 3 suites
duration  38.2 seconds
commit  3f4b8f1
info  🔄 Run: #23414 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #23414 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  37.2 seconds
commit  3f4b8f1
info  🔄 Run: #23414 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #23414 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  31.7 seconds
commit  3f4b8f1
info  🔄 Run: #23414 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #23413 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  2 passed

Details

stats  2 tests across 2 suites
duration  33.7 seconds
commit  7eeb80a
info  🔄 Run: #23413 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #23413 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  3 passed

Details

stats  3 tests across 3 suites
duration  35.7 seconds
commit  7eeb80a
info  🔄 Run: #23413 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #23413 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  33.1 seconds
commit  7eeb80a
info  🔄 Run: #23413 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #23413 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  37.7 seconds
commit  7eeb80a
info  🔄 Run: #23413 (attempt 1)

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Visual Regression

26 screenshots compared. See report for details.
View full report

The Value tab's stays in the page behind the Dependencies tab.
Screen readers don't reliably announce labels on plain spans, so the count is
read out in full as visually hidden text, which the E2E test also finds the tab
by.
RTK Query keeps the previous arguments' data while new ones load, so a changed
environment or flag could briefly show the previous one's prerequisites.
@github-actions github-actions Bot removed the feature New feature or request label Nov 18, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 4 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Auto-approval blocked by 1 unresolved issue from previous reviews.

Turn on auto-fix | Re-trigger cubic

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: f604f92d-f0d0-43fc-8333-b78f30bd726b
Commits

Reviewing files that changed from the base of the PR and between 8d74c07 and 8ecf60a.

Files selected for processing: 1

  • frontend/web/components/modals/create-feature/index.tsx

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.

The hook's test only checks what it requests, as the query is mocked.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 2 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Adds prerequisite status to feature tabs and loads all flag pages. In versioned edits, the status still reflects live dependencies while the tab can show staged changes, so its behavior needs human review.

Turn on auto-fix | Re-trigger cubic

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: fd3b9e13-f096-49a2-9ea9-8a7073e7aa49
Commits

Reviewing files that changed from the base of the PR and between 8ecf60a and 7eeb80a.

Files selected for processing: 2

  • frontend/common/hooks/__tests__/useFeatureStates.test.ts
  • frontend/common/utils/__tests__/recursivePageGet.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Shows prerequisite status on the Value tab and counts met prerequisites on the Dependencies tab, loading all feature-list pages. Human review needed: versioned 4-eyes edits still count live dependencies while the tab can show staged rows.

Turn on auto-fix | Re-trigger cubic

The chip inherited the tab's line height, 42px, which stretched it.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Adds a prerequisite-status banner and tab counter, loading all feature-list pages. Human review needed: during versioned 4-eyes edits, the status/counter reflect live dependencies while the Dependencies tab shows staged rows.

Turn on auto-fix | Re-trigger cubic

@talissoncosta talissoncosta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the changes!

@linear-code

linear-code Bot commented Nov 18, 2026

Copy link
Copy Markdown

ENG-654

@khvn26
khvn26 merged commit dba691d into main Nov 18, 2026
32 checks passed
@khvn26
khvn26 deleted the feat/flag-dependencies-value-tab branch November 18, 2026 20:41

This branch was successfully deployed

2 active deployments
Preview – flagsmith-frontend-preview — aad90cec Deployed Nov 18, 2026 by vercel[bot]
Preview – flagsmith-frontend-staging — aad90cec Deployed Nov 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flag dependencies are not reflected in the feature Value tab

2 participants