You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat(Flags): Show flag dependencies on the Value tab - #8989
In this PR, we show a flag's dependencies outside its Dependencies tab:
The Value tab warns when prerequisites serve the flag off in the environment, as the Dependencies tab does, with a button to the flag's dependencies.
The Dependencies tab's label counts the prerequisites met, e.g. 1/2, highlighted while any is off.
Both show wherever the Dependencies tab does, i.e. not for identity overrides or change requests, and only once the flag's dependencies and the feature list have loaded, as prerequisites would read as off without the latter.
We also read whether flags are on from every page of the feature list, rather than its first 999 flags, which read any prerequisite beyond them as off, in this PR and the Dependencies tab alike.
Screenshots
A flag with two prerequisites, one of them off:
The tab's counter:
"View dependencies" opens the Dependencies tab:
With both prerequisites on, the counter turns neutral and the warning goes:
How did you test this code?
Added unit tests for counting the prerequisites met, and steps to the flag dependencies E2E test.
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
The feature modal now loads prerequisite status for eligible existing features. The Dependencies tab displays a count of met prerequisites. When prerequisite rows and an environment name are available, the Value tab displays a blocked banner with an optional “View dependencies” action. End-to-end checks cover the count, blocked message, tab navigation, and count after enabling the prerequisite.
The change adds prerequisite status to the Value and Dependencies tabs and now reads flag states across all pages. Remaining issues are minor: the banner count can disagree with the badge when custom dependencies exist, a late save error can be lost after tab switching, and the manual visual-baseline script cannot run before this UI merges. Nothing here blocks merging.
- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.
Screen readers don't reliably announce labels on plain spans, so the count is
read out in full as visually hidden text, which the E2E test also finds the tab
by.
RTK Query keeps the previous arguments' data while new ones load, so a changed
environment or flag could briefly show the previous one's prerequisites.
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.
The reason will be displayed to describe this comment to others. Learn more.
0 issues found across 2 files (changes from recent commits).
Confidence score: 5/5
Automated review surfaced no issues in the provided summaries.
No files require special attention.
Requires human review: Adds prerequisite status to feature tabs and loads all flag pages. In versioned edits, the status still reflects live dependencies while the tab can show staged changes, so its behavior needs human review.
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.
The reason will be displayed to describe this comment to others. Learn more.
0 issues found across 1 file (changes from recent commits).
Confidence score: 5/5
Automated review surfaced no issues in the provided summaries.
No files require special attention.
Requires human review: Shows prerequisite status on the Value tab and counts met prerequisites on the Dependencies tab, loading all feature-list pages. Human review needed: versioned 4-eyes edits still count live dependencies while the tab can show staged rows.
The reason will be displayed to describe this comment to others. Learn more.
0 issues found across 1 file (changes from recent commits).
Confidence score: 5/5
Automated review surfaced no issues in the provided summaries.
No files require special attention.
Requires human review: Adds a prerequisite-status banner and tab counter, loading all feature-list pages. Human review needed: during versioned 4-eyes edits, the status/counter reflect live dependencies while the Dependencies tab shows staged rows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
featureNew feature or requestfront-endIssue related to the React Front End Dashboard
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Closes #8855.
Closes ENG-654.
In this PR, we show a flag's dependencies outside its Dependencies tab:
1/2, highlighted while any is off.Both show wherever the Dependencies tab does, i.e. not for identity overrides or change requests, and only once the flag's dependencies and the feature list have loaded, as prerequisites would read as off without the latter.
We also read whether flags are on from every page of the feature list, rather than its first 999 flags, which read any prerequisite beyond them as off, in this PR and the Dependencies tab alike.
Screenshots
A flag with two prerequisites, one of them off:
The tab's counter:
"View dependencies" opens the Dependencies tab:
With both prerequisites on, the counter turns neutral and the warning goes:
How did you test this code?
Added unit tests for counting the prerequisites met, and steps to the flag dependencies E2E test.