Skip to content

feat(chip): add success and warning variants - #9002

Merged
talissoncosta merged 2 commits into
mainfrom
feat/chip-warning-variant
Nov 17, 2026
Merged

talissoncosta merged 2 commits into
mainfrom
feat/chip-warning-variant

Conversation

@talissoncosta

@talissoncosta talissoncosta commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Contributes to #8989

Adds success and warning variants to Chip, for status such as a flag's unmet prerequisites (#8989) and the permission summary chips. The border colours live in Chip.scss, like accent.

How did you test this code?

Checked the new Success and Warning stories and the Group story in Storybook, light and dark.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
flagsmith-frontend-preview Ready Ready Preview Nov 17, 2026 7:49pm UTC
flagsmith-frontend-staging Ready Ready Preview Nov 17, 2026 7:49pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Preview Nov 17, 2026 7:49pm UTC

Request Review

@talissoncosta
talissoncosta requested a review from a team as a code owner November 17, 2026 18:57
@talissoncosta
talissoncosta requested review from kyle-ssg and removed request for a team November 17, 2026 18:57
@talissoncosta talissoncosta self-assigned this Nov 17, 2026
@talissoncosta
talissoncosta requested a review from khvn26 November 17, 2026 18:57
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The chip component adds success and warning variants. It maps each variant to surface and text tokens and applies the matching class to untinted chips. The stylesheet adds border colours for both variants. Storybook adds Success and Warning stories and includes Live and Paused chips in the Group story.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: Minimal · up to 46590

This adds success and warning chip styles with matching Storybook examples. The change is small and self-contained, and no merge-blocking issue was found.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: fbf39b25-e40d-44f2-a890-7b4528cafad1
Commits

Reviewing files that changed from the base of the PR and between 8fef7d6 and 46590d3.

Files selected for processing: 3

  • frontend/documentation/components/Chip.stories.tsx
  • frontend/web/components/base/Chip/Chip.scss
  • frontend/web/components/base/Chip/Chip.tsx

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-9002 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-9002 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-private-cloud:pr-9002 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-9002 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-api:pr-9002 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-9002 Finished ✅ Results ✅

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: de530834-f190-441d-ad3c-7e6e3d88f092
Commits

Reviewing files that changed from the base of the PR and between b5fc451 and 8fef7d6.

Files selected for processing: 3

  • frontend/documentation/components/Chip.stories.tsx
  • frontend/web/components/base/Chip/Chip.scss
  • frontend/web/components/base/Chip/Chip.tsx

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor
✅ private-cloud · depot-ubuntu-latest-16 — run #23383 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  4 passed

Details

stats  4 tests across 4 suites
duration  34.6 seconds
commit  46590d3
info  🔄 Run: #23383 (attempt 1)

🗂️ Previous results
✅ oss · depot-ubuntu-latest-arm-16 — run #23383 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  34.4 seconds
commit  46590d3
info  🔄 Run: #23383 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #23383 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  6 passed

Details

stats  6 tests across 6 suites
duration  18.8 seconds
commit  46590d3
info  🔄 Run: #23383 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #23383 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  30.6 seconds
commit  46590d3
info  🔄 Run: #23383 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-16 — run #23376 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  55.7 seconds
commit  8fef7d6
info  🔄 Run: #23376 (attempt 1)

✅ private-cloud · depot-ubuntu-latest-arm-16 — run #23376 (attempt 1)

Playwright Test Results (private-cloud - depot-ubuntu-latest-arm-16)

passed  5 passed

Details

stats  5 tests across 4 suites
duration  7.7 seconds
commit  8fef7d6
info  🔄 Run: #23376 (attempt 1)

✅ oss · depot-ubuntu-latest-16 — run #23376 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  32.8 seconds
commit  8fef7d6
info  🔄 Run: #23376 (attempt 1)

✅ oss · depot-ubuntu-latest-arm-16 — run #23376 (attempt 1)

Playwright Test Results (oss - depot-ubuntu-latest-arm-16)

passed  1 passed

Details

stats  1 test across 1 suite
duration  35.8 seconds
commit  8fef7d6
info  🔄 Run: #23376 (attempt 1)

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Visual Regression

25 screenshots compared. See report for details.
View full report

cubic-dev-ai[bot]
cubic-dev-ai Bot previously approved these changes Nov 17, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@talissoncosta talissoncosta changed the title feat(Chip): Add a warning variant feat(Chip): Add success and warning variants Nov 17, 2026
@github-actions github-actions Bot added feature New feature or request and removed feature New feature or request labels Nov 17, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 3 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: Adds success/warning variants to the Chip component (border and utility classes) plus Storybook coverage; the dismissed border !important concern doesn't apply because the chip draws its own border and doesn't use Bootstrap's .border utility.

Turn on auto-fix | Re-trigger cubic

@talissoncosta talissoncosta changed the title feat(Chip): Add success and warning variants feat(chip): add success and warning variants Nov 17, 2026
@talissoncosta
talissoncosta merged commit 0dd2d9a into main Nov 17, 2026
31 of 32 checks passed
@talissoncosta
talissoncosta deleted the feat/chip-warning-variant branch November 17, 2026 20:22

This branch was successfully deployed

2 active deployments
Preview – flagsmith-frontend-staging — 46590d3d Deployed Nov 17, 2026 by vercel[bot]
Preview – flagsmith-frontend-preview — 46590d3d Deployed Nov 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants