You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat(chip): add success and warning variants - #9002
Adds success and warning variants to Chip, for status such as a flag's unmet prerequisites (#8989) and the permission summary chips. The border colours live in Chip.scss, like accent.
How did you test this code?
Checked the new Success and Warning stories and the Group story in Storybook, light and dark.
No actionable comments were generated in the recent review.
Walkthrough
The chip component adds success and warning variants. It maps each variant to surface and text tokens and applies the matching class to untinted chips. The stylesheet adds border colours for both variants. Storybook adds Success and Warning stories and includes Live and Paused chips in the Group story.
This adds success and warning chip styles with matching Storybook examples. The change is small and self-contained, and no merge-blocking issue was found.
- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review.
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.
The reason will be displayed to describe this comment to others. Learn more.
0 issues found across 3 files (changes from recent commits).
Confidence score: 5/5
Automated review surfaced no issues in the provided summaries.
No files require special attention.
Auto-approved: Adds success/warning variants to the Chip component (border and utility classes) plus Storybook coverage; the dismissed border !important concern doesn't apply because the chip draws its own border and doesn't use Bootstrap's .border utility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
featureNew feature or requestfront-endIssue related to the React Front End Dashboard
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Contributes to #8989
Adds
successandwarningvariants toChip, for status such as a flag's unmet prerequisites (#8989) and the permission summary chips. The border colours live inChip.scss, likeaccent.How did you test this code?
Checked the new
SuccessandWarningstories and theGroupstory in Storybook, light and dark.