Repository navigation
Add reader selections, highlight actions and unobtrusive controls - #8
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 991cc7ed3c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Fixed the Linux PDF test timeout in a6db5a8. The failed job logs show that PDFium could not find its shared library or Both selection layouts pass in an isolated checkout without the Dart native-assets map, and analysis/formatting pass. The Linux CI rerun is pending. This commit changes test setup only. |
|
Fixed the browser smoke timeout in ecc55c4. The script still expected controls to be visible immediately after opening each book, and expected Automatic rather than Single columns. It now waits for book content, verifies the controls start hidden, taps to reveal them, and checks the new single-column default. The keyboard-only chapter navigation scenario starts in the default focus mode. Validated the complete |
Text selection now offers actions beside the selected passage and saved highlights can be edited or removed. Mouse selection no longer turns pages, both EPUB columns are selectable, and PDF mouse selection opens an Annotate/Copy toolbar.
The reader exposes serializable EPUB text ranges and PDF page rectangles for host-owned persistence, plus highlight actions and toolbar/panel builders. Books start in one column with controls hidden. Chrome uses the host theme with single header/footer borders.
Validation: 199 reader tests and 2 example tests passed, reader/example analysis and worker consistency checks passed. A real Chrome/PDFium mouse-drag check confirmed the PDF toolbar and annotation callback. Mobile device acceptance remains unrun.
Closes #7. Supports FR-3_4 and FR-4_1.
The coordinated client PR pins this commit. Merge this reader PR before client#94. Server persistence is in server#50.