Skip to content

Add reader selections, highlight actions and unobtrusive controls - #8

Merged
Eoic merged 4 commits into
developmentfrom
feature/reader-library-tools
Oct 26, 2026
Merged

Eoic merged 4 commits into
developmentfrom
feature/reader-library-tools

Conversation

@Eoic

@Eoic Eoic commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Text selection now offers actions beside the selected passage and saved highlights can be edited or removed. Mouse selection no longer turns pages, both EPUB columns are selectable, and PDF mouse selection opens an Annotate/Copy toolbar.

The reader exposes serializable EPUB text ranges and PDF page rectangles for host-owned persistence, plus highlight actions and toolbar/panel builders. Books start in one column with controls hidden. Chrome uses the host theme with single header/footer borders.

Validation: 199 reader tests and 2 example tests passed, reader/example analysis and worker consistency checks passed. A real Chrome/PDFium mouse-drag check confirmed the PDF toolbar and annotation callback. Mobile device acceptance remains unrun.

Closes #7. Supports FR-3_4 and FR-4_1.

The coordinated client PR pins this commit. Merge this reader PR before client#94. Server persistence is in server#50.

Copilot AI balanced review requested due to automatic review settings October 26, 2026 19:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T19:39:39.671201Z 991cc7e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 991cc7ed3c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Eoic commented Oct 26, 2026

Copy link
Copy Markdown
Member Author

Fixed the Linux PDF test timeout in a6db5a8. The failed job logs show that PDFium could not find its shared library or .dart_tool/native_assets.yaml, and its worker left initialization waiting until the test timeout. The test now loads the explicit library path from Flutter's generated build/native_assets/<os>/native_assets.json, validates that the file exists, and bounds initialization/document operations to 15 seconds. The test itself has a one-minute timeout.

Both selection layouts pass in an isolated checkout without the Dart native-assets map, and analysis/formatting pass. The Linux CI rerun is pending. This commit changes test setup only.

Eoic commented Oct 26, 2026

Copy link
Copy Markdown
Member Author

Fixed the browser smoke timeout in ecc55c4. The script still expected controls to be visible immediately after opening each book, and expected Automatic rather than Single columns. It now waits for book content, verifies the controls start hidden, taps to reveal them, and checks the new single-column default. The keyboard-only chapter navigation scenario starts in the default focus mode.

Validated the complete npm test browser smoke suite against a fresh flutter build web, using the installed Playwright Chromium. All worker, EPUB, file import/error, focus/keyboard, responsive settings, PDF navigation/scroll/refit and theme-menu checks passed. Node syntax and diff checks passed. CI run 45 also confirms the preceding PDFium fix passed both Flutter test steps on Linux. The new CI run is pending.

@Eoic
Eoic merged commit 9aaf5f2 into development Oct 26, 2026
8 checks passed
@Eoic
Eoic deleted the feature/reader-library-tools branch October 26, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support EPUB/PDF selections, annotations and reader controls

2 participants