Skip to content

Add reader library tabs and exact saved-location navigation - #94

Merged
Eoic merged 4 commits into
developmentfrom
feature/reader-library-tools
Oct 26, 2026
Merged

Eoic merged 4 commits into
developmentfrom
feature/reader-library-tools

Conversation

@Eoic

@Eoic Eoic commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Reader contents now groups chapters, bookmarks, annotations and freehand notes into tabs, with a full-screen contents page on mobile and a desktop side panel. Bookmark icons toggle the current location and show saved/pending state without success alerts. Annotation actions come from text selection and saved highlights, while notes are created from the toolbar or panel FAB.

Bookmarks and annotations open their recorded EPUB/PDF location from book details and dedicated pages. Edit forms hide location metadata and preserve the stored anchor. Offline storage and PowerSync mapping retain locators and selection geometry, with guards against writes after a profile switch.

Pins papyrus_reader to 388a12a2ef26c933d59891416c17f4e69e4122e4 from reader#8, including single-column defaults, hidden initial controls, selection fixes, and matching panel colors/borders. The local path override is excluded.

Initial validation: 1,965 client tests passed with 19 skips in an isolated checkout using the committed Git reader dependency. Client formatting, analysis, four web bootstrap tests and a release web build passed. Final review corrected the stale annotation-editor test and removed unused note-anchor serialization. The reader's real Chrome/PDFium selection check confirmed its floating toolbar and annotation callback. Live cross-device sync and mobile device acceptance remain unrun.

Review follow-up: saved EPUB titles now use the nearest preceding TOC section, with anchor offsets resolved by the pinned reader. All 16 focused client tests and analysis passed in an isolated checkout against the updated Git dependency. Reader keyboard-focus regressions and server malformed-rectangle tests also pass.

Dependencies: merge reader#8 first. Deploy server#50, including the additive migration and PowerSync stream update, before releasing this client.

Closes #93. Supports FR-3_4, FR-4_1 and FR-4_2.

Copilot AI balanced review requested due to automatic review settings October 26, 2026 19:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T19:42:37.758509Z b5dc79b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b5dc79bf4c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/lib/reader/reader_library.dart Resolved
@Eoic
Eoic enabled auto-merge October 26, 2026 19:51
@Eoic
Eoic merged commit a17d544 into development Oct 26, 2026
4 of 6 checks passed
@Eoic
Eoic deleted the feature/reader-library-tools branch October 26, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate reader bookmarks, annotations, notes and saved-location navigation

2 participants