Repository navigation
fix(config): configure Delaunay.areas_factor and dPIE ra/rs notation - #630
Merged
Merged
Conversation
priors/mesh/delaunay.yaml was a bare `Delaunay:`, so af.Model(ag.mesh.Delaunay)
(and al.mesh.Delaunay) reported "areas_factor Prior Missing". Configure it as
a Constant at the class default (0.5), the value autolens_workspace already
sets.
notation.yaml had no label/label_format for the dPIE `ra` and `rs`
parameters, so both fell back to the first-letter label "r". Add r_{\rm a} /
r_{\rm s} and '{:.4f}', matching autolens_workspace.
Tests: Delaunay model has no missing prior; dPIE ra/rs labels are not the
fallback (both red before the config change). The model-figure semantics
test used Delaunay.areas_factor as its real-class witness of the `missing`
state; it now uses CurvatureMask.coefficient (still unconfigured), and the
Delaunay test pins areas_factor as a fixed Constant.
Refs PyAutoLabs/PyAutoMind#441
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Sep 27, 2026
Closed
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two library config gaps that workspaces were papering over:
config/priors/mesh/delaunay.yamlwas a bareDelaunay:, soaf.Model(ag.mesh.Delaunay)/al.mesh.Delaunayreportedareas_factor Prior Missing. It is now aConstantat the class default0.5(the value autolens_workspace already sets).config/notation.yamlhad nolabel/label_formatfor the dPIEra/rsparameters, so both fell back to the first-letter labelr. Addsr_{\rm a}/r_{\rm s}and'{:.4f}', matching autolens_workspace.Part of PyAutoLabs/PyAutoMind#441 (workspace-config-cleanup).
Merge order: merge this PR first — the companion PyAutoLabs/PyAutoLens#751's model-figure acceptance tests depend on this config. Workspace PRs (autofit_workspace, autogalaxy_workspace, autolens_workspace, autocti_workspace) follow in the same task and remove the now-redundant workspace overrides.
Heart YELLOW acknowledged by human (reasons: manifest drift: hub organism blurb (organs present) — 7 mismatches; manifest drift: organism-map blocks (generated) — 1 mismatch; manifest drift: workspace checkouts (manifest ↔ disk) — 1 mismatch; release validation stale: source moved since rehearsal (PyAutoFit, PyAutoArray, PyAutoGalaxy, PyAutoLens)).
API Changes
No Python API change. Config-default change: Delaunay models now get
areas_factor = 0.5as a fixedConstantfrom library config (previously it needed a workspace prior, or was reported as Missing). dPIEra/rsnow have their own LaTeX labels.See full details below.
Test Plan
test_autogalaxy/test_priors_config.py)ra/rslabels are not the fallback (test_dual_pseudo_isothermal_mass.py) — both red before the config changetest_model_figure_semantics.py: real-classmissing-state witness movedDelaunay.areas_factor→reg.CurvatureMask.coefficientpython -m pytest test_autogalaxy/— 1243 passedFull API Changes (for automation & release notes)
Changed Behaviour
autogalaxy/config/priors/mesh/delaunay.yaml—Delaunay.areas_factorconfigured asConstantvalue: 0.5;af.Model(ag.mesh.Delaunay)no longer reports a missing prior and has one fewer free parameter slot.autogalaxy/config/notation.yaml—label.ra: r_{\rm a},label.rs: r_{\rm s},label_format.ra/rs: '{:.4f}'.Migration
areas_factor/ the dPIE labels themselves keep working (workspace config still overrides); those overrides become redundant.Generated by the PyAutoLabs agent workflow.
🤖 Generated with Claude Code