Repository navigation
test(model_figure): move the missing-state witness off Delaunay.areas_factor - #751
Merged
Merged
Conversation
…_factor PyAutoGalaxy now configures Delaunay.areas_factor as a Constant (0.5), so the MGE pixelized acceptance case has no unconfigured parameter: areas_factor is a fixed Constant row, fixed_leaf_slots 64 -> 65, missing 1 -> 0. The real-class witness of the `missing` state moves to the same lens model with its regularization swapped for al.reg.CurvatureMask, whose `coefficient` still has no prior configured (row missing/ConfigException, one missing, 13 sampled, "coefficient · missing" pill). mge_pixelized() takes an optional regularization class; its docstring is updated. Refs PyAutoLabs/PyAutoMind#441 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Sep 27, 2026
Merged
Closed
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PyAutoGalaxy now configures
Delaunay.areas_factoras aConstant(0.5) (PyAutoLabs/PyAutoGalaxy#630), so the MGE-pixelized model-figure acceptance case no longer has an unconfigured parameter. This PR updates the witness:areas_factoris now a fixedConstantrow — counts 65 fixed / 0 missing (was 64 / 1).missingstate moves to the same lens model with its regularization swapped foral.reg.CurvatureMask, whosecoefficientstill has no configured prior (new test).lens_models.mge_pixelized()takes an optionalregularizationclass.Part of PyAutoLabs/PyAutoMind#441 (workspace-config-cleanup).
Merge order: merge PyAutoLabs/PyAutoGalaxy#630 first. These tests need the new Galaxy config and will fail against PyAutoGalaxy main until it lands. Workspace PRs (autofit_workspace, autogalaxy_workspace, autolens_workspace, autocti_workspace) follow in the same task.
Heart YELLOW acknowledged by human (reasons: manifest drift: hub organism blurb (organs present) — 7 mismatches; manifest drift: organism-map blocks (generated) — 1 mismatch; manifest drift: workspace checkouts (manifest ↔ disk) — 1 mismatch; release validation stale: source moved since rehearsal (PyAutoFit, PyAutoArray, PyAutoGalaxy, PyAutoLens)).
API Changes
None — internal changes only. (Test-only: the
test_autolens/model_figure/lens_models.mge_pixelizedhelper gains an optionalregularization=Nonekwarg.)Test Plan
test_acceptance_lens.py— MGE-pixelized case:areas_factorfixed Constant, 65 fixed / 0 missingtest__mge__unconfigured_regularization_coefficient_is_missing(CurvatureMask coefficient → missing / ConfigException, one missing, 13 sampled)python -m pytest test_autolens/— 759 passed (against the PyAutoGalaxy#630 branch)Full API Changes (for automation & release notes)
Changed Signature
test_autolens/model_figure/lens_models.mge_pixelized(regularization=None)— internal test helper; defaults toal.reg.ConstantSplitas before.Generated by the PyAutoLabs agent workflow.
🤖 Generated with Claude Code