Repository navigation
Fix accidental closing of add/edit wine bottom sheet (fixes #10) - #27
Merged
Merged
Conversation
Block hide transitions when forms are dirty via confirmValueChange, use skipPartiallyExpanded to avoid half-expanded scrim taps, and prompt to discard on explicit close or scrim tap. Add unit tests for dirty detection. Co-authored-by: T0liver <T0liver@users.noreply.github.com>
This was referenced Nov 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10
Cause
WineFormSheetusedskipPartiallyExpanded = falsewithout guarding sheet hide. Light drags and scrim taps calledonDismissRequest, which unmounted the sheet and incrementedwineFormSessionIdon the next open—wipingrememberSaveableform state.Fix
SheetFormDirty.kt) and rejectSheetValue.HiddeninconfirmValueChangeunless dismissal is intentional.skipPartiallyExpanded = trueto avoid the large half-expanded scrim tap target.WineFilterSheet.SheetFormDirtyTestunit tests.Build
./gradlew assembleDebug testDebugUnitTest— SUCCESS