Skip to content

M2.14 COMTRADE: include exact-directory same-basename RIO sidecars in downloads - #170

Closed
masarray wants to merge 2 commits into
integration/m214-pinned-engine-baseline-20261016from
fix/m214-comtrade-rio-sidecar-20261016
Closed

masarray wants to merge 2 commits into
integration/m214-pinned-engine-baseline-20261016from
fix/m214-comtrade-rio-sidecar-20261016

Conversation

@masarray

Copy link
Copy Markdown
Owner

Pinned-engine interoperability repair

BCUGE presents COMTRADE CFG/DAT and .RIO (relay-settings) with an identical base name. The existing engine catalog only recognizes CFG/DAT/HDR/INF and therefore omits RIO from both the logical record and the transactional downloader.

  • Add an explicit RioSidecar file kind, recognize .RIO case-insensitively and aggregate only under the existing remote-directory + base-name RecordId.
  • RIO never satisfies the CFG/DAT completeness condition and a lone RIO is not promoted into a downloadable fault record.
  • The existing bounded, transactionally validated fault-record downloader already enumerates record.Files and includes the sidecar automatically. No second transfer loop, no filename guessing from GUI.
  • Test complete exact grouping, different directory, orphan file, incomplete CFG+RIO, duplicate listing.

Safe base: an immutable branch at ARSAS pinned engine 036e2c00d83a0815b6160147b14ea05975057965. Deliberately not upgrading the unrelated 119 engine commits in current main. This draft is an isolated compatible candidate for ARSAS pin testing; production engine main integration requires independent review. No MMS writes or IED state mutations.

masarray added a commit that referenced this pull request Oct 22, 2026
#170 source and regression-test blobs are copied verbatim after confirming their original merge-base blobs match the engine #190 integration tree. Include main infrastructure PR #191 as explicit parent and use its identical checked workflow blob; avoid future conflicts. No ARSAS repin, no main engine source merge, no field qualification. This candidate needs fresh Windows synthetic-merge CI.

Copy link
Copy Markdown
Owner Author

Repository consolidation audit, 2026-10-22: exact source HEAD aecaa3c73519d53e86223c8d1226f3ffd99a6743 was verified as a Git ancestor (0 missing commits) of canonical combined draft PR #190 HEAD 14b19d30466fd296ad1e6d0bddcdd574992bc464. PR #190 validated this exact integration via Windows merge-tree CI #39778971482: 1,262/1,262 tests pass, zero build errors or warnings.

Closing this original PR as CONSOLIDATED / SUPERSEDED BY #190, WITHOUT merging it directly to main. All branch refs, original commits, engineering discussion and FAT evidence remain preserved and recoverable. #190 remains DRAFT, not field/physical accepted, engine source not yet merged to main, ARSAS pin unchanged. Reopen if consolidation is withdrawn or its functionality becomes independently active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant