Repository navigation
Consolidated engine #190: 7 source PRs • 1262 Windows tests green (DRAFT) - #190
Conversation
#170 source and regression-test blobs are copied verbatim after confirming their original merge-base blobs match the engine #190 integration tree. Include main infrastructure PR #191 as explicit parent and use its identical checked workflow blob; avoid future conflicts. No ARSAS repin, no main engine source merge, no field qualification. This candidate needs fresh Windows synthetic-merge CI.
…CL semantics #138 Consolidate exact #130 12 new SV analysis/docs/tests blobs and #138 four proven non-overlapping discovery/SCL source and test blobs; Iec61850StandardModelRegistry.cs already byte-identical to #138. Explicit parents preserve source ancestry. No updates to main or ARSAS engine lock, no release/FAT qualification. Validate exact merged candidate via Windows CI.
|
Staging-only acceptance, 2026-10-22. Branch |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Controlled ARIEC61850 consolidation — integration candidate, NOT release
This is the single reviewed consolidation lane for repository audit issue #144. Do not merge merely because the tree is conflict-free or CI green. Preserve ARSAS FAT evidence and immutable engine lock.
Pinned source commits / ancestry
24aae4698026f3a5cf7a35225c5d8000018af3e4(179 commits ahead of legacy main).d095b3ac9bdf6687f7ab9407f7e28eca9c168c94(3 distinct source/test files).4ed76ccd11b763dcd847395f6ef45273db3f5c9c(4 distinct source/test files).ded5036029706db1a752bb045d1fbc43b67fe9c6(3 distinct SCL source/test files; old workflow change intentionally replaced).aecaa3c73519d53e86223c8d1226f3ffd99a6743(2 unique source/test paths, verified same blobs as Consolidated engine #190: 7 source PRs • 1262 Windows tests green (DRAFT) #190 ancestor).5077d6ac1e8394ec789f90b3b33cad3260ab0241(inherits verified first integration commitef17070f3c5aa333c1789ada52296959703d9f5d, source M2.14 COMTRADE: include exact-directory same-basename RIO sidecars in downloads #170 and merged CI infrastructure CI: validate synthetic PR merge on every stacked base (workflow-only) #191 at3d21238d0b62f24faecd5948a4ee238c82b35966as explicit parents). No force push; no production code merge.Why this composition is safe to test, not yet to ship
For each of the 10 source/test paths from the three siblings, compared exact Git blob IDs at its original merge-base to #189: all unchanged on #189 (zero overlapping modifications). Installed sibling file blobs verbatim into #189's base tree. Original eleven-path integration plus two COMTRADE RIO source/test paths (#170); the CI infrastructure workflow has since been squash-merged independently as #191, and this branch now adopts the exact same workflow blob:
pull_requeston any target branch;actions/checkoutat event SHA, default PR synthetic merge commit, notGITHUB_HEAD_REF/branch checkout;Mandatory qualification gates before main merge
5077d6ac, run #39771920122: checked outrefs/pull/190/merge(merge tree506620cover main3d21238); source/provenance gate, restore, Release build, 1,231/1,231 tests passed, NuGet test build, artifacts and diagnostics upload; 0 build warnings/errors. Historical integration HEADef17070fseparately passed run #39770688304, 1,227/1,227 tests. Mainline workflow-only CI: validate synthetic PR merge on every stacked base (workflow-only) #191 separately passed run #39771262606, 993/993.9c7cb40364023a7b217e5ec31ab3105ba90142ebuntil separately approved. #666 timing trial uses P0 SBO Enhanced: per-invoke TPKT send / confirmed response / decode timing (no safety change) #187 separately; not promoted here.Provenance and public API boundaries
No raw customer SCL/captures or private diagnostics added. No engine pin change.
mainnow contains workflow-only infrastructure squash PR #191 at3d21238d0b62f24faecd5948a4ee238c82b35966; engine source remains at the original mainline baseline. PR is draft intentionally; reviewer should confirm post-merge test and readiness before production.2026-10-22 consolidation increment — #130 SV + #138 typed semantics
Current integration SHA:
14b19d30466fd296ad1e6d0bddcdd574992bc464, fast-forwarded from5077d6ac1e8394ec789f90b3b33cad3260ab0241(no rewrite). Additional preserved source parents:66a325c6414ce8c007a0a758ee33e8b2d92e7bb3: 12 original new files (SV sustained stream analysis, engineering-window/SCL-bound measurements, documentation, deterministic tests), no overlapping destination paths.5d8c9959f638290a7aaf45988ef45ed823639d2a: four source/test blobs exact-copy from a merge-base unchanged destination; the fifth sharedIec61850StandardModelRegistry.csalready had the exact same blob hash. No semantic overwrite.All original functional changes from #189/#186/#187/#182/#170 remain ancestry. Prior green 1,231/1,231 CI on
5077d6acdoes not qualify this new SHA; require a new green exact merged-tree CI. The new SV engine analysis is not itself proof of physical SMV/relay behavior. Remaining divergent #137/#160/#155/#175/old P0–P6 stack and #171 dependency updates have not been silently imported. Engine release and ARSAS lock updates are explicitly blocked pending separate acceptance.Exact post-consolidation Windows gate — PASS
14b19d30466fd296ad1e6d0bddcdd574992bc464checked out as PR Consolidated engine #190: 7 source PRs • 1262 Windows tests green (DRAFT) #190 synthetic merge49ae033against main3d21238d0b62f24faecd5948a4ee238c82b35966.5077d6ac. Physical FAT, ARSAS combined immutable-lock build and remaining divergent feature reconciliation not satisfied by software gate. Keep PR DRAFT and main engine source unchanged.