Skip to content

fix(deps): upgrade workspace React while preserving plugin compatibility - #39

Merged
SoonIter merged 3 commits into
mainfrom
fix/react-19
Oct 15, 2026
Merged

SoonIter merged 3 commits into
mainfrom
fix/react-19

Conversation

@SoonIter

@SoonIter SoonIter commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Upgrade the workspace and plugin template to React 19.2.8, including React DOM and React 19 types, while keeping the published third-parties plugin compatible with React 18 and React 19. Rspress stays at 2.0.22.

Keep react and react-dom peer dependencies at ^18.0.0 || ^19.0.0. Disable React Compiler for the plugin and remove both its compiler and runtime dependencies, so published components require neither react-compiler-runtime nor react/compiler-runtime. Preserve the React 18 resource API fallback and use a patch changeset. Resource API tests now assert the behavior supported by the installed React version.

Validation:

  • Frozen install, package build, lint/type-check, docs build, and 13 unit tests passed.
  • React 19.2.8: all 56 E2E tests passed.
  • React 18.3.1: all 27 third-parties E2E tests passed, with no skips. This validation used temporary React/React DOM 18 and Markdown renderer 18 overrides, explicit React links in the nested fixture, and clean Rspack caches; the committed workspace remains on React 19.
  • Built plugin artifacts contain no compiler runtime imports.

Copilot AI balanced review requested due to automatic review settings October 15, 2026 03:43

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T04:11:57.853731Z 0f217fb New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@SoonIter SoonIter changed the title fix(deps): migrate plugins to React 19 fix(deps): upgrade workspace React while preserving plugin compatibility Oct 15, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0f217fb179

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SoonIter
SoonIter merged commit 661a3e0 into main Oct 15, 2026
2 checks passed
@SoonIter
SoonIter deleted the fix/react-19 branch October 15, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants