Repository navigation
fix(syntax): parse Snowflake CLONE kinds and security AS REPLICA forms - #55
Merged
Merged
Conversation
…flake-clone-replica
CREATE ... CLONE now parses for ALERT, STAGE, STREAM, SEQUENCE, FILE FORMAT, DATABASE ROLE, EVENT TABLE and the dynamic, Iceberg, temporary and volatile tables into CreateObject with source CLONE, with the documented time travel clause and trailing options. Database, schema and table clones take their typed time travel and documented options. CREATE CONNECTION, FAILOVER GROUP and REPLICATION GROUP ... AS REPLICA OF org.account.name parse into CreateObject with source REPLICA. The polyglot exact check lists the typed time travel clause as a kept field, since polyglot keeps it as raw text.
…flake-clone-replica # Conflicts: # crates/sqlquack-syntax/tests/parser.rs
…flake-clone-replica
Outside Snowflake, CREATE SCHEMA and CREATE DATABASE kept their clone time travel clause with the same loop; it is now one helper, which keeps commands.rs within the file length limit after the merge.
Contributor
Author
|
Gate (D94) on 77e10ee, which contains main 497ad27 (#54): Coverage diff against main 497ad27 (gate-profile checker, same catalogue and evidence tree for both): +5 forms, +405 obligations, 0 lost. Gained: create-alert-clone, create-clone.database-schema-clone, create-clone.event-table-clone, create-clone.table-clone, create-stage-clone. Since the description was written: merged gaps-e 497ad27, and the schema and database clones share their raw AT/BEFORE capture outside Snowflake, so commands.rs stays within the file length limit. Landing by fast-forward. |
kvlonge
added a commit
that referenced
this pull request
Nov 5, 2026
kvlonge
added a commit
that referenced
this pull request
Nov 5, 2026
Snowflake reads CREATE DATABASE ROLE ; and CREATE DATABASE ROLE CLONE d2 as a database named ROLE (recorded success); #55 took them as a database role without a name.
kvlonge
added a commit
that referenced
this pull request
Nov 5, 2026
… whatever it expects The snapshot took Snowflake's verdict from a case's checked phase, which is none for every observe case, so a receipted observe case the parser stopped accepting never reached the diff (#55's three regressions, audit 38bed22). Each case result now carries what Snowflake's parser did, by every syntax receipt of its SQL, setup and session whatever the case id: parsed when all stopped after parsing with an errno other than 1003, refused when all are a positioned 1003 or a 921, and nothing for a positionless 1003 or receipts that disagree. The diff fails on a parsed case the parser now rejects, as before, and also on a refused case it now accepts.
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parses the CREATE ... CLONE kinds lane C kept and the security AS REPLICA forms, on top of #54 (gaps-e).
CreateObjectwith sourceCLONE, reusing fix(syntax): parser gaps batch e (TASK CLONE, CREATE … FROM, quoting, recorded refusals) #54's node. Each takes the documented time travel clause{ AT | BEFORE } ( { TIMESTAMP | OFFSET | STATEMENT } => <expr> )as a typedHistoricalData, and its documented trailing options (COPY GRANTS, COPY TAGS, COPY = ( … ), TARGET_LAG, WAREHOUSE, EXECUTE AS USER, USE SECONDARY ROLES). Any other trailing word is refused. CREATE ROLE … CLONE is refused, since Snowflake clones only a DATABASE ROLE.CreateDatabasegains apropertieslist (skipped when empty).CreateObjectwith sourceREPLICA; only a connection takes COMMENT.at_clause/clone_at_clauseare listed as kept fields, andtests/parser/test_snowflake_create_clone.rspins the trees.Receipted clone cases: 268 of 268 scored right (99 before). AS REPLICA cases have no receipts yet (the replication holds), but all 84 catalogue expectations match. Coverage diff against main 0c8952e, on the 0c8952e catalogue and evidence through import 121: +15 forms, +775 obligations, 0 lost. Seven of those forms are this PR's clone forms; the other eight came with #54.
Gate:
make check-merge RECORDER=0is running on 77e10ee; the result will be posted here.