Repository navigation
fix(syntax): keep OR REPLACE and quoting on Snowflake database and schema clones - #56
Merged
Merged
Conversation
…clones CreateDatabase and CreateSchema now record OR REPLACE, which was parsed and dropped, and a Snowflake database name keeps its quoting.
Snowflake reads CREATE DATABASE ROLE ; and CREATE DATABASE ROLE CLONE d2 as a database named ROLE (recorded success); #55 took them as a database role without a name.
Snowflake parses CREATE STREAM v1 CLONE v1 COPY = ( ) and fails later (errno 1422), so the clone options now accept an empty kind list. Adds regression cases for it and for CREATE DATABASE ROLE CLONE v1, and keeps the database-role doc comment on one line.
Contributor
Author
|
Gate (D94) on c793813, base main 77e10ee:
|
kvlonge
added a commit
that referenced
this pull request
Nov 5, 2026
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the auditor's D118 withholds on main 497ad27 (record c1a92df) for
sf.ddl.create-database.create-database-clone(quoted names, OR REPLACE) andsf.ddl.create-schema.create-schema-clone(OR REPLACE).CreateDatabaseandCreateSchemagainor_replace, which is skipped when false so other trees are unchanged. OR REPLACE was parsed and then dropped.parse_quoting_identifier).tests/parser/test_snowflake_create_clone.rspins the three trees.The parser tests and the polyglot exact check pass. Gate:
make check-merge RECORDER=0is running on 0faa5be; the result will be posted here.