refactor: replace SensorBox architecture - #46
Closed
Foxpace wants to merge 32 commits into
Closed
Conversation
This was referenced Aug 19, 2026
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the original SensorBox refactor stack, PRs #14 through #44. It is the only review target for the refactor and architecture pass.
The base is
master, so GitHub's Files changed view shows the final repository state. Intermediate interfaces and implementations removed by later commits are not part of the review diff.What changed
core-commonandrecording-coremodules.AppResult<T>with stable, data-only application errors.sensorservicesand removed its Wear transport dependency.docs/architecture-refactor-plan.md.Earlier review feedback
PR #14 contains the only review threads in the old stack. Its
AppDiagnosticsthreads target a class deleted by this change and replaced byFileDiagnosticsplus the Settings diagnostics flow. The preference grouping andNativeDocumentStorageAPI notes still refer to current code, so they remain visible in #14 and should be judged against their current implementations here.Validation
./gradlew testDebugUnitTest lintDebug assembleDebugAndroidTest assembleDebug detekt./gradlew :core-common:test :recording-core:testtools/emulator/run_phone_sensor_test.sh:OK (1 test)SensorBox_Wear_API_37still needs one-time phone/watch pairing in Android Studio beforetools/emulator/run_wear_sync_test.shcan run.