Repository navigation
ci(warden): Run code-review and sdk-review on draft PRs - #5944
Merged
Merged
Conversation
Co-Authored-By: Ricardo Oliveira <ricardo.oliveira@sentry.io>
This was referenced Nov 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5944 +/- ##
=======================================
Coverage 77.43% 77.44%
=======================================
Files 546 546
Lines 20053 20053
Branches 3962 3962
=======================================
+ Hits 15529 15531 +2
+ Misses 3659 3658 -1
+ Partials 865 864 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sentry-junior
Bot
requested review from
jamescrosswell and
ric-oliv
as code owners
November 16, 2026 12:49
dingsdax
approved these changes
Nov 16, 2026
This was referenced Nov 17, 2026
Litarnus
added a commit
to getsentry/sentry-laravel
that referenced
this pull request
Nov 17, 2026
Adds a `warden.toml` that runs Warden's built-in `code-review` skill on PRs, alongside the org-wide `security-review`. `warden.toml` is also marked `export-ignore` in `.gitattributes` so it doesn't ship in the package dist. The trigger has no `draft = false` filter on purpose, so PRs that go from draft to ready don't get missed. The org Warden workflow is a ruleset-required workflow, and GitHub only runs those on `opened`, `synchronize`, and `reopened` ([docs](https://docs.github.com/en/enterprise-cloud@latest/repositories/configuring-branches-and-merges-in-your-repository/managing-rulesets/available-rules-for-rulesets)), whatever `types` they list. So `ready_for_review` never reaches Warden, and with a draft filter a PR opened as a draft and marked ready without a new push would never be reviewed. Reviewing drafts as commits land means the PR is already reviewed when it leaves draft. `incremental = true` keeps each push limited to what changed since the last run. getsentry/sentry-dotnet#5944 made the same change for the same reason. `phpstan-baseline.neon` is ignored since it's a generated baseline. <!-- junior-request-attribution:start --> via **Martin Linzmayer**. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:slack%3AC0C9S0HKR7Y%3A1794923812.653509 --> -- [View Session](https://junior-prod.sentry.dev/conversations/slack%3AC0C9S0HKR7Y%3A1794923812.653509) [[Sentry]](https://sentry.sentry.io/explore/conversations/slack%3AC0C9S0HKR7Y%3A1794923812.653509/?project=4510944073809921) <!-- junior-session-footer:end --> --------- Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: Martin Linzmayer <martin.linzmayer@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
code-reviewandsdk-reviewcurrently skip draft PRs (draft = false). We usually open PRs as drafts and mark them ready without pushing again, so neither skill reviews them. This happened on #5930 and #5932.Triggering on
ready_for_reviewcan't fix this. The org Warden workflow is a ruleset-required workflow, and GitHub only runs those onopened,synchronize, andreopened, whatevertypesthey list.This change removes the draft filter, so both skills review drafts as commits are pushed. Both are
incremental, so each push only reviews what changed since the last run.#skip-changelog
via Ricardo Oliveira.
--
View Session [Sentry]