Skip to content

ci(warden): Run code-review and sdk-review on draft PRs - #5944

Merged
ric-oliv merged 1 commit into
mainfrom
ci/warden-review-drafts
Nov 16, 2026
Merged

ric-oliv merged 1 commit into
mainfrom
ci/warden-review-drafts

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

code-review and sdk-review currently skip draft PRs (draft = false). We usually open PRs as drafts and mark them ready without pushing again, so neither skill reviews them. This happened on #5930 and #5932.

Triggering on ready_for_review can't fix this. The org Warden workflow is a ruleset-required workflow, and GitHub only runs those on opened, synchronize, and reopened, whatever types they list.

This change removes the draft filter, so both skills review drafts as commits are pushed. Both are incremental, so each push only reviews what changed since the last run.

#skip-changelog

via Ricardo Oliveira.

--

View Session [Sentry]

Co-Authored-By: Ricardo Oliveira <ricardo.oliveira@sentry.io>
@codecov

codecov Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.44%. Comparing base (b9a48d2) to head (ddee361).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5944   +/-   ##
=======================================
  Coverage   77.43%   77.44%           
=======================================
  Files         546      546           
  Lines       20053    20053           
  Branches     3962     3962           
=======================================
+ Hits        15529    15531    +2     
+ Misses       3659     3658    -1     
+ Partials      865      864    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sentry-junior
sentry-junior Bot marked this pull request as ready for review November 16, 2026 12:49
@github-actions github-actions Bot added the risk: medium PR risk score: medium label Nov 16, 2026
@ric-oliv
ric-oliv requested a review from dingsdax November 16, 2026 13:22
@ric-oliv
ric-oliv merged commit 7cc4546 into main Nov 16, 2026
44 checks passed
@ric-oliv
ric-oliv deleted the ci/warden-review-drafts branch November 16, 2026 16:02
Litarnus added a commit to getsentry/sentry-laravel that referenced this pull request Nov 17, 2026
Adds a `warden.toml` that runs Warden's built-in `code-review` skill on
PRs, alongside the org-wide `security-review`. `warden.toml` is also
marked `export-ignore` in `.gitattributes` so it doesn't ship in the
package dist.

The trigger has no `draft = false` filter on purpose, so PRs that go
from draft to ready don't get missed. The org Warden workflow is a
ruleset-required workflow, and GitHub only runs those on `opened`,
`synchronize`, and `reopened`
([docs](https://docs.github.com/en/enterprise-cloud@latest/repositories/configuring-branches-and-merges-in-your-repository/managing-rulesets/available-rules-for-rulesets)),
whatever `types` they list. So `ready_for_review` never reaches Warden,
and with a draft filter a PR opened as a draft and marked ready without
a new push would never be reviewed. Reviewing drafts as commits land
means the PR is already reviewed when it leaves draft. `incremental =
true` keeps each push limited to what changed since the last run.
getsentry/sentry-dotnet#5944 made the same change for the same reason.

`phpstan-baseline.neon` is ignored since it's a generated baseline.

<!-- junior-request-attribution:start -->
via **Martin Linzmayer**.
<!-- junior-request-attribution:end -->

<!-- junior-session-footer:start -->
<!-- junior-conversation-id:slack%3AC0C9S0HKR7Y%3A1794923812.653509 -->

--

[View
Session](https://junior-prod.sentry.dev/conversations/slack%3AC0C9S0HKR7Y%3A1794923812.653509)
[[Sentry]](https://sentry.sentry.io/explore/conversations/slack%3AC0C9S0HKR7Y%3A1794923812.653509/?project=4510944073809921)

<!-- junior-session-footer:end -->

---------

Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>
Co-authored-by: Martin Linzmayer <martin.linzmayer@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk: medium PR risk score: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants